[Fix #928] Adding config and secret manager #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fjtirado <ftirados@redhat.com>
fjtirado
commented
Oct 31, 2025
| secretManager = | ||
| ServiceLoader.load(SecretManager.class) | ||
| .findFirst() | ||
| .orElseGet(() -> s -> configManager.config(s, String.class)); |
Collaborator
Author
There was a problem hiding this comment.
By default secrets are properties!
| configManager = | ||
| ServiceLoader.load(ConfigManager.class) | ||
| .findFirst() | ||
| .orElseGet(() -> new SystemPropertyConfigManager()); |
Collaborator
Author
There was a problem hiding this comment.
By default properties are java system properties
fjtirado
commented
Oct 31, 2025
| String name, WorkflowAdditionalObject<T> additionalObject) { | ||
| if (additionalObjects == null) { | ||
| additionalObjects = new ConcurrentHashMap<>(); | ||
| additionalObjects = new HashMap<>(); |
Collaborator
Author
There was a problem hiding this comment.
Unrelated, but this can be a regular hashmap, since syncrhonization is not required for unvariant hashmap like this one once the application is built
fjtirado
commented
Oct 31, 2025
| public record WorkflowError( | ||
| String type, int status, String instance, String title, String details) { | ||
|
|
||
| public static final Errors.Standard RUNTIME_TYPE = Errors.RUNTIME; |
Collaborator
Author
There was a problem hiding this comment.
Those two ones were never used. I was trying to avoid accesing Errors from runtime context, but at the end is kind of confusing
impl/test/src/test/java/io/serverlessworkflow/impl/test/SecretExpressionTest.java
Show resolved
Hide resolved
ricardozanini
approved these changes
Oct 31, 2025
…ExpressionTest.java Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #929 and #926